Skip to content

Commit

Permalink
ksconf sort: Cleanup unit tests
Browse files Browse the repository at this point in the history
- Remove old/confusing (likely copy-n-paste comments)
- Update some regexes to support wider range output order
  • Loading branch information
lowell80 committed Jan 26, 2023
1 parent eb208cf commit 3e7c218
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions tests/test_cli_sort.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def test_bad_file(self):
self.assertEqual(ko.returncode, EXIT_CODE_BAD_CONF_FILE)

def test_sort_mixed(self):
# Not yet implemented. Currently relying on the shell to do this.
with ksconf_cli:
ko = ksconf_cli("sort", "-i", *self.all_confs)
self.assertEqual(ko.returncode, EXIT_CODE_BAD_CONF_FILE)
Expand All @@ -94,7 +93,6 @@ def test_sort_mixed(self):
self.assertRegex(ko.stderr, r"Skipping no-sort file [^ ]+[/\\]transforms\.conf")

def test_sort_stdout(self):
# Not yet implemented. Currently relying on the shell to do this.
with ksconf_cli:
ko = ksconf_cli("sort", self.conf_bogus, self.no_sort)
self.assertEqual(ko.returncode, EXIT_CODE_SUCCESS)
Expand All @@ -104,7 +102,6 @@ def test_sort_stdout(self):
"transforms.conf should be sorted even with KSCONF-NO-SORT directive for non-inplace mode")

def test_sort_mixed_quiet(self):
# Not yet implemented. Currently relying on the shell to do this.
with ksconf_cli:
ko = ksconf_cli("sort", "-i", "--quiet", *self.all_confs)
self.assertEqual(ko.returncode, EXIT_CODE_BAD_CONF_FILE)
Expand Down

0 comments on commit 3e7c218

Please sign in to comment.