Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDEV-784: Create function should support also a single item #285

Conversation

b-stolyarov
Copy link
Contributor

Description

The create function should support also a single item.

Changes

Added create(entity: T, callback: KinveyClientCallback<T>) function to DataStore class.

Tests

Instrumented.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #285 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
+ Coverage     62.48%   62.76%   +0.27%     
- Complexity      609      622      +13     
============================================
  Files            43       44       +1     
  Lines          2844     2860      +16     
  Branches        841      845       +4     
============================================
+ Hits           1777     1795      +18     
+ Misses          534      530       -4     
- Partials        533      535       +2     
Impacted Files Coverage Δ Complexity Δ
...ava/com/kinvey/android/async/AsyncCreateRequest.kt 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...rc/main/java/com/kinvey/android/store/DataStore.kt 68.05% <100.00%> (-0.24%) 48.00 <1.00> (+2.00) ⬇️
...c/main/java/com/kinvey/android/cache/RealmCache.kt 78.06% <0.00%> (+0.05%) 154.00% <0.00%> (+1.00%)
.../com/kinvey/android/async/AsyncBatchPushRequest.kt 47.05% <0.00%> (+3.92%) 24.00% <0.00%> (+8.00%)
.../java/com/kinvey/android/AndroidCredentialStore.kt 58.00% <0.00%> (+4.00%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d691ee1...9a5add6. Read the comment docs.

Copy link

@alexanderfilipov alexanderfilipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a whole.

@b-stolyarov b-stolyarov merged commit 4f9f0a3 into master Jul 15, 2020
@b-stolyarov b-stolyarov deleted the feature/KDEV-784_Create_function_should_support_also_a_single_item branch July 15, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants