use cross-spawn #4
Conversation
|
@Kinvey Can you merge this and release on NPM? This would make a huge difference for Windows folks. |
|
Ping. |
There was a problem hiding this comment.
@miguelcobain curious if you have the time to include an update to the README for instructions to install on Windows, if not I can take a stab at it when I have a chance.
| @@ -25,6 +25,7 @@ | |||
| "dependencies": { | |||
| "broccoli-kitchen-sink-helpers": "^0.2.5", | |||
| "coffee-script": "^1.7.1", | |||
| "cross-spawn": "^2.0.0", | |||
There was a problem hiding this comment.
Perhaps this should be bumped to a more recent version, cross-spawn has been updated to 6.0.5
There was a problem hiding this comment.
I think it should be fine, yes. Looks like the api didn't change at all.
|
@patrickjholloway unfortunately I'm no longer on a windows machine, but I remember this being a relatively safe change to make. |
|
@miguelcobain okay, sounds good. I do want to test this out and add an entry to the README. I will take care of this soon and merge. Thank you for the PR and sorry for the huge delay. |
|
@patrickjholloway do we have any progress here? |
|
@patrickjholloway any news here ? |
|
Going to close the PR. Will be reopened in case it is needed at some point. |
closes #3