Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2450: Don't clear the active user when using local storage #311

Merged
merged 4 commits into from Jun 22, 2018

Conversation

@thomasconner
Copy link
Contributor

commented Jun 21, 2018

Description

Clearing the cache used by the datastore will clear the stored active user when the SDK is set to use LocalStorage as the persistence adapter for the datastore cache.

Changes

  • Do not clear the active user collection when clearing the datastore cache and using the local storage adapter.

Tests

  • Add integration test to verify

@thomasconner thomasconner requested a review from vinaygahlawat Jun 21, 2018

@thomasconner thomasconner self-assigned this Jun 21, 2018

@vinaygahlawat
Copy link
Contributor

left a comment

Overall LGTM. But what do the package-lock.json changes have to do with this fix?

@thomasconner

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2018

It wasn't meant to be. The change is actually in the master branch. I am not sure why it is showing up here. The package-lock.json is a file autogenerated when you run npm install.

@thomasconner thomasconner merged commit 841593a into master Jun 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-2450 branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.