Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2450: Don't clear the active user when using local storage #311

Merged
merged 4 commits into from Jun 22, 2018

Conversation

thomasconner
Copy link
Contributor

Description

Clearing the cache used by the datastore will clear the stored active user when the SDK is set to use LocalStorage as the persistence adapter for the datastore cache.

Changes

  • Do not clear the active user collection when clearing the datastore cache and using the local storage adapter.

Tests

  • Add integration test to verify

@thomasconner thomasconner self-assigned this Jun 21, 2018
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. But what do the package-lock.json changes have to do with this fix?

@thomasconner
Copy link
Contributor Author

It wasn't meant to be. The change is actually in the master branch. I am not sure why it is showing up here. The package-lock.json is a file autogenerated when you run npm install.

@thomasconner thomasconner merged commit 841593a into master Jun 22, 2018
@thomasconner thomasconner deleted the MLIBZ-2450 branch June 22, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants