Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2095: bugfix for the infinite loop if dynamic keyword is not used #243

Merged
merged 1 commit into from Oct 2, 2017

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Sep 25, 2017

Description

Bugfix for the infinite loop in case the user forgets to add the dynamic keyword in the property

Changes

  • Fixing the ObjCRuntime class to not get stucked in a infinite loop in case the property does not have a dynamic keyword

Tests

  • Since this is a infinite loop it's hard to find a way to write a unit test for it

@heyzooi heyzooi self-assigned this Sep 25, 2017
@heyzooi heyzooi force-pushed the feature/MLIBZ-2095-forget_dynamic_infinite_loop branch 2 times, most recently from 62d9e42 to 43fd418 Compare September 28, 2017 09:04
@codecov-io
Copy link

codecov-io commented Sep 28, 2017

Codecov Report

Merging #243 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #243      +/-   ##
==========================================
+ Coverage    90.37%   90.4%   +0.03%     
==========================================
  Files           65      65              
  Lines         7976    7976              
==========================================
+ Hits          7208    7211       +3     
+ Misses         768     765       -3
Flag Coverage Δ
#Mac 87.69% <ø> (ø) ⬆️
#iOS 89.3% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.77%) ⬆️
Kinvey/Kinvey/Client.swift 92.57% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12f4bf...8fae248. Read the comment docs.

@heyzooi heyzooi force-pushed the feature/MLIBZ-2095-forget_dynamic_infinite_loop branch from 43fd418 to 8fae248 Compare September 29, 2017 08:41
@heyzooi
Copy link
Contributor Author

heyzooi commented Oct 2, 2017

the fix itself was included during our Swift 4 migration.
Here's the fix: c5c23df#diff-b6fd1f03d32320489ca9966c5f370602R86

Copy link
Contributor

@tejasranade tejasranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyzooi heyzooi merged commit af113cb into develop Oct 2, 2017
@heyzooi heyzooi deleted the feature/MLIBZ-2095-forget_dynamic_infinite_loop branch October 2, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants