MLIBZ-2343: adding Options for Client #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #264 +/- ##
===========================================
+ Coverage 87.69% 87.77% +0.07%
===========================================
Files 68 68
Lines 8447 8562 +115
===========================================
+ Hits 7408 7515 +107
- Misses 1039 1047 +8
Continue to review full report at Codecov.
|
tejasranade
reviewed
Feb 9, 2018
| validateInitialize(appKey: appKey, appSecret: appSecret) | ||
| self.encryptionKey = encryptionKey | ||
| self.schemaVersion = schema?.version ?? 0 | ||
| self.options = options | ||
| if let timeout = options?.timeout { |
There was a problem hiding this comment.
If options.timeout is our preferred way to set global timeouts, let's deprecate Client.timeoutInterval.
There was a problem hiding this comment.
sure, let me do this
tejasranade
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
One improvement, otherwise LGTM.
@heyzooi - make sure all our tests and docs point to this new API definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Options for Client constructor
Changes
Tests