MLIBZ-2490: pull with skip should not remove cached records #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyzooi
requested review from
thomasconner,
tejasranade,
vinaygahlawat and
Martin-Hristov
| @@ -39,7 +39,7 @@ internal class PullOperation<T: Persistable>: FindOperation<T> where T: NSObject | |||
| } | |||
|
|
|||
| override var mustRemoveCachedRecords: Bool { | |||
There was a problem hiding this comment.
Where does this get called? Can you link to a line number?
There was a problem hiding this comment.
PullOperation extends from FindOperation, here's the line in FindOperation:
swift-sdk/Kinvey/Kinvey/FindOperation.swift
Line 299 in 4032b16
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
===========================================
+ Coverage 88.39% 89.26% +0.87%
===========================================
Files 70 70
Lines 8351 9001 +650
===========================================
+ Hits 7382 8035 +653
+ Misses 969 966 -3
Continue to review full report at Codecov.
|
thomasconner
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When skip and limit is used we should not remove cached records
Changes
PullOperationnow checks if theskipandlimitarenilto determine if local records should be deleted before save the records pulled from the serverTests