Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2491: recovering correctly when the delta set is not available #289

Merged

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented May 17, 2018

Description

Recovering when the delta set is not enabled in the backend

Changes

  • Setting FindOperation.deltaSet to false if we detected the delta set feature is not enabled in the backend

Tests

  • Unit Test
1. Enable auto-pagination and deltaset in a store and pull
2. Disable deltaset in the backend of an app and create 10 items in the collection
3. Pull with maxSizePerResultSet = 3

Expected result: Pull performs deltaset request that fails because the deltaset is not enabled in the backend and then a regular GET is made using auto-pagination and maxSizePerResultSet

@codecov-io
Copy link

codecov-io commented May 17, 2018

Codecov Report

Merging #289 into develop will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #289      +/-   ##
===========================================
+ Coverage    89.16%   89.32%   +0.15%     
===========================================
  Files           70       70              
  Lines         8981     8982       +1     
===========================================
+ Hits          8008     8023      +15     
+ Misses         973      959      -14
Flag Coverage Δ
#Mac 88.52% <100%> (+0.09%) ⬆️
#iOS 88.11% <100%> (+0.07%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/FindOperation.swift 96.12% <100%> (+0.36%) ⬆️
Kinvey/Kinvey/FileStore.swift 87.82% <0%> (+0.13%) ⬆️
Kinvey/Kinvey/PushOperation.swift 94% <0%> (+1%) ⬆️
Kinvey/Kinvey/CacheManager.swift 97.22% <0%> (+2.77%) ⬆️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+3.08%) ⬆️
Kinvey/Kinvey/Operation.swift 83.95% <0%> (+6.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7ad95...219e35b. Read the comment docs.

Copy link

@Martin-Hristov Martin-Hristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyzooi heyzooi merged commit 7e0499b into develop May 22, 2018
@heyzooi heyzooi deleted the feature/MLIBZ-2491-deltaset_misconfigation_autopagination branch May 22, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants