Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-921: Swift Package Manager Support #302

Merged
merged 13 commits into from
Oct 1, 2019

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Jun 26, 2018

Description

Swift Package Manager Beta Support

Changes

This task required a few updates in our dependencies:

DaveWoodCom/XCGLogger#261 (Merged)

tjboneman/NSPredicate-MongoDB-Adaptor#9 (Merged)

tristanhimmelman/ObjectMapper#982 (Closed)

kishikawakatsumi/KeychainAccess#387 (Still Open)

pubnub/objective-c#376 (Still Open, using https://github.com/heyzooi/objective-c/ for now)

realm/realm-swift#5828 (Closed)

Tests

  • Same Unit Tests to ensure everything is working as expected

@heyzooi heyzooi self-assigned this Jun 26, 2018
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the ObjectMapper dependency have to be removed from this now?

Kinvey/Kinvey/MemoryCache.swift Outdated Show resolved Hide resolved
Kinvey/KinveyTests/GetOperationTest.swift Outdated Show resolved Hide resolved
Kinvey/KinveyTests/MyFile.swift Outdated Show resolved Hide resolved
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch 2 times, most recently from c68652d to 11769fa Compare July 12, 2018 00:43
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch 4 times, most recently from 62846a3 to e94b984 Compare September 21, 2018 20:04
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch 2 times, most recently from 989b1ab to e6c8ea9 Compare October 3, 2018 23:21
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from 49cda06 to cc49187 Compare October 18, 2018 23:27
@codecov-io
Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #302 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #302      +/-   ##
==========================================
- Coverage     86.3%   86.3%   -0.01%     
==========================================
  Files           82      82              
  Lines        10108   10112       +4     
==========================================
+ Hits          8724    8727       +3     
- Misses        1384    1385       +1
Flag Coverage Δ
#Mac 84.67% <100%> (ø) ⬆️
#iOS 86.12% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
Kinvey/Kinvey/Query.swift 80.8% <ø> (ø) ⬆️
Kinvey/Kinvey/Kinvey.swift 91.05% <ø> (ø) ⬆️
Kinvey/Kinvey/RealmCache.swift 89.18% <100%> (+0.08%) ⬆️
Kinvey/Kinvey/HttpRequest.swift 87.81% <100%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4973258...53a01f7. Read the comment docs.

@heyzooi heyzooi changed the title MLIBZ-921: Swift Package Manager Beta Support MLIBZ-921: Swift Package Manager Beta Support (WIP) Oct 26, 2018
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from bfa7183 to 9ebccba Compare November 2, 2018 22:02
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from 9fdb639 to d9c8c4d Compare November 27, 2018 21:22
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from 948970f to 2fd0438 Compare December 20, 2018 21:39
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from 2fd0438 to d14686f Compare February 27, 2019 21:53
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from d14686f to 3a975c0 Compare April 15, 2019 17:31
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch 5 times, most recently from 0e12768 to 2446cb9 Compare May 2, 2019 20:18
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from 2446cb9 to ae8e077 Compare May 28, 2019 18:44
@heyzooi heyzooi closed this Sep 20, 2019
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from ae8e077 to b1c80f0 Compare September 20, 2019 19:14
@heyzooi heyzooi reopened this Sep 20, 2019
@heyzooi heyzooi force-pushed the feature/MLIBZ-921-spm_support branch from f29e665 to fd6ddd8 Compare September 26, 2019 21:39
@heyzooi heyzooi changed the title MLIBZ-921: Swift Package Manager Beta Support (WIP) MLIBZ-921: Swift Package Manager Beta Support Sep 30, 2019
@heyzooi heyzooi changed the title MLIBZ-921: Swift Package Manager Beta Support MLIBZ-921: Swift Package Manager Support Sep 30, 2019
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but just a few clarifying questions, including: why were the following files deleted? Do we have coverage for what they used to cover?

Kinvey/KinveyTests/GetOperationTest.swift
Kinvey/KinveyTests/SaveOperationTest.swift

.travis.yml Outdated Show resolved Hide resolved
Kinvey/KinveyTests/AutoDataStoreSpec.swift Show resolved Hide resolved
@heyzooi heyzooi merged commit 1285fe1 into develop Oct 1, 2019
@heyzooi heyzooi deleted the feature/MLIBZ-921-spm_support branch October 1, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants