-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLIBZ-921: Swift Package Manager Support #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the ObjectMapper dependency have to be removed from this now?
c68652d
to
11769fa
Compare
62846a3
to
e94b984
Compare
989b1ab
to
e6c8ea9
Compare
49cda06
to
cc49187
Compare
Codecov Report
@@ Coverage Diff @@
## develop #302 +/- ##
==========================================
- Coverage 86.3% 86.3% -0.01%
==========================================
Files 82 82
Lines 10108 10112 +4
==========================================
+ Hits 8724 8727 +3
- Misses 1384 1385 +1
Continue to review full report at Codecov.
|
bfa7183
to
9ebccba
Compare
9fdb639
to
d9c8c4d
Compare
948970f
to
2fd0438
Compare
2fd0438
to
d14686f
Compare
d14686f
to
3a975c0
Compare
0e12768
to
2446cb9
Compare
2446cb9
to
ae8e077
Compare
ae8e077
to
b1c80f0
Compare
f29e665
to
fd6ddd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but just a few clarifying questions, including: why were the following files deleted? Do we have coverage for what they used to cover?
Kinvey/KinveyTests/GetOperationTest.swift
Kinvey/KinveyTests/SaveOperationTest.swift
Description
Swift Package Manager Beta Support
Changes
This task required a few updates in our dependencies:
DaveWoodCom/XCGLogger#261 (Merged)
tjboneman/NSPredicate-MongoDB-Adaptor#9 (Merged)
tristanhimmelman/ObjectMapper#982 (Closed)
kishikawakatsumi/KeychainAccess#387 (Still Open)
pubnub/objective-c#376 (Still Open, using https://github.com/heyzooi/objective-c/ for now)
realm/realm-swift#5828 (Closed)
Tests