Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2581: replacing all fatalErrors() calls to throw Errors instead #305

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Jul 11, 2018

Description

Replacing all fatalErrors() calls to throw Errors instead so the user can recover from it

Changes

  • Many files affected since once a method is marked as throws, meaning it can throw an Error, all methods that calls the method need to either handle the error or rethrows the error

Tests

  • Same unit tests is actually the best way test the change, with a few changes where the unit tests where expecting a fatalError()

@heyzooi heyzooi self-assigned this Jul 11, 2018
@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@c35ca13). Click here to learn what that means.
The diff coverage is 79.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #305   +/-   ##
==========================================
  Coverage           ?   88.82%           
==========================================
  Files              ?       71           
  Lines              ?     8840           
  Branches           ?        0           
==========================================
  Hits               ?     7852           
  Misses             ?      988           
  Partials           ?        0
Flag Coverage Δ
#Mac 86.96% <78.86%> (?)
#iOS 87.73% <79.65%> (?)
Impacted Files Coverage Δ
Kinvey/Kinvey/Cache.swift 87.34% <0%> (ø)
Kinvey/Kinvey/PurgeOperation.swift 95.38% <100%> (ø)
Kinvey/Kinvey/SyncManager.swift 100% <100%> (ø)
Kinvey/Kinvey/HttpRequest.swift 80.55% <100%> (ø)
Kinvey/Kinvey/Request.swift 98% <100%> (ø)
Kinvey/Kinvey/GetOperation.swift 100% <100%> (ø)
Kinvey/Kinvey/CountOperation.swift 100% <100%> (ø)
Kinvey/Kinvey/CustomEndpoint.swift 98.42% <100%> (ø)
Kinvey/Kinvey/RemoveByIdOperation.swift 100% <100%> (ø)
Kinvey/Kinvey/User.swift 95.6% <100%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35ca13...fb55de9. Read the comment docs.

Copy link
Contributor

@thomasconner thomasconner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the amount of changes it is hard to determine if anything was missed but from my initial pass everything that was changed made sense and looks good to me. I am approving the PR but we should wait for the tests to complete before merging.

@heyzooi heyzooi force-pushed the feature/MLIBZ-2581-no_fatalerrors branch from f03ce93 to 347b202 Compare July 11, 2018 18:12
@heyzooi heyzooi force-pushed the feature/MLIBZ-2581-no_fatalerrors branch from 347b202 to e16269c Compare July 11, 2018 18:27
@heyzooi heyzooi merged commit ef47fd6 into develop Jul 11, 2018
@heyzooi heyzooi deleted the feature/MLIBZ-2581-no_fatalerrors branch July 11, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants