Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2838: Bugfix crash on signpost calls #346

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Jan 4, 2019

Description

Adding {public} to the signpost calls when handled strings

Changes

  • Signpost calls now uses %@ instead of %s for string formatting

Tests

  • Same unit tests

@codecov-io
Copy link

Codecov Report

Merging #346 into develop will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    85.59%   85.82%   +0.22%     
===========================================
  Files           70       70              
  Lines         8721     8788      +67     
===========================================
+ Hits          7465     7542      +77     
+ Misses        1256     1246      -10
Flag Coverage Δ
#Mac 83.8% <100%> (?)
#iOS 85.82% <100%> (+0.22%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/RealmCache.swift 89.55% <ø> (ø) ⬆️
Kinvey/Kinvey/RealmSync.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/DeviceInfo.swift 90.8% <0%> (-7.77%) ⬇️
Kinvey/Kinvey/Kinvey.swift 87.38% <0%> (-1.19%) ⬇️
Kinvey/Kinvey/FileStore.swift 87.35% <0%> (+0.64%) ⬆️
Kinvey/Kinvey/PushOperation.swift 94.33% <0%> (+0.94%) ⬆️
Kinvey/Kinvey/HttpRequest.swift 88.85% <0%> (+4.87%) ⬆️
Kinvey/Kinvey/Operation.swift 95.58% <0%> (+7.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b47d4d...f388bf1. Read the comment docs.

@heyzooi heyzooi changed the title WIP: Bugfix crash on signpost calls MLIBZ-2838: Bugfix crash on signpost calls Jan 8, 2019
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the change here is to use %@ instead of %s, but the PR description states the opposite. Which is the correct way to do this?

@heyzooi
Copy link
Contributor Author

heyzooi commented Jan 14, 2019

@vinaygahlawat sorry, just fixed, %@ is the correct one

@heyzooi heyzooi merged commit 11e5ec5 into develop Jan 14, 2019
@heyzooi heyzooi deleted the feature/crash_bugfix_signpost branch January 14, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants