Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLIBZ-2888: Make Client.userChangedListener public #352

Merged
merged 1 commit into from
Feb 27, 2019
Merged

MLIBZ-2888: Make Client.userChangedListener public #352

merged 1 commit into from
Feb 27, 2019

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Feb 26, 2019

Description

Making Client.userChangedListener public allows perform actions when the user is not present anymore, like in situations where the token expired for example

Changes

  • Client.userChangedListener is now public

Tests

  • Same unit tests

@heyzooi heyzooi self-assigned this Feb 26, 2019
vinaygahlawat
vinaygahlawat approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's make sure all the tests are passing before merging.

@heyzooi heyzooi merged commit 5062654 into develop Feb 27, 2019
@heyzooi heyzooi deleted the feature/MLIBZ-2888-userChangedListener_public branch February 27, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinaygahlawat vinaygahlawat vinaygahlawat approved these changes

Assignees

@heyzooi heyzooi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heyzooi @vinaygahlawat