Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-3022: Multi-Record Insert #359

Merged
merged 4 commits into from
May 28, 2019

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented May 16, 2019

Description

Multi-Record Insert implementation

Changes

  • DataStore, new SaveMultiOperation and code around it

Tests

  • Unit Tests:
    • Happy Path (saving an array of items)
    • Trying to save the same _id
    • Trying to save an empty array
    • Saving exactly 100 records
    • Saving more than 100 records

@heyzooi heyzooi self-assigned this May 16, 2019
@heyzooi heyzooi force-pushed the feature/MLIBZ-3017-multi-record-insert branch from 7c96d9f to 195236f Compare May 16, 2019 05:34
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@69e560e). Click here to learn what that means.
The diff coverage is 83.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #359   +/-   ##
=========================================
  Coverage           ?   86.2%           
=========================================
  Files              ?      72           
  Lines              ?    9775           
  Branches           ?       0           
=========================================
  Hits               ?    8427           
  Misses             ?    1348           
  Partials           ?       0
Flag Coverage Δ
#Mac 84.48% <83.82%> (?)
#iOS 85.97% <83.82%> (?)
Impacted Files Coverage Δ
Kinvey/Kinvey/ObjectMapperJSONParser.swift 0% <0%> (ø)
Kinvey/Kinvey/Kinvey.swift 93.12% <100%> (ø)
Kinvey/Kinvey/DataStore.swift 79.89% <100%> (ø)
Kinvey/Kinvey/HttpRequest.swift 89.26% <100%> (ø)
Kinvey/Kinvey/JSONParser.swift 86.41% <100%> (ø)
Kinvey/Kinvey/Error.swift 89.56% <100%> (ø)
Kinvey/Kinvey/HttpResponse.swift 79.54% <100%> (ø)
Kinvey/Kinvey/HttpRequestFactory.swift 86.67% <100%> (ø)
Kinvey/Kinvey/RealmCache.swift 91.2% <100%> (ø)
Kinvey/Kinvey/Cache.swift 85.88% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e560e...8c2aa7a. Read the comment docs.

Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Per our side conversation, please add in the handling of an array of entities that are a mix of both creates and updates before we merge this PR.

Kinvey/Kinvey/HttpRequest.swift Outdated Show resolved Hide resolved
Kinvey/Kinvey/SaveMultiOperation.swift Outdated Show resolved Hide resolved
heyzooi and others added 2 commits May 28, 2019 09:44
* Amends to cover existing items

* add index to errors in existing items

* fixing mock tests
@heyzooi heyzooi merged commit 43beee5 into develop May 28, 2019
@heyzooi heyzooi deleted the feature/MLIBZ-3017-multi-record-insert branch May 28, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants