Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support drop column #109

Merged
merged 5 commits into from Dec 18, 2023
Merged

feat: support drop column #109

merged 5 commits into from Dec 18, 2023

Conversation

KKould
Copy link
Member

@KKould KKould commented Dec 16, 2023 •
edited

What problem does this PR solve?

features:

  • support drop column for alert table
    • alter table t1 drop column if exists v1
  • support unique_index for add column

fmt

  • ColumnCatalog::add_index_meta

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould linked an issue Dec 16, 2023 that may be closed by this pull request
DDL Support #97
Open
12 tasks
@KKould KKould requested a review from guojidan December 16, 2023 09:15
@KKould KKould added the enhancement New feature or request label Dec 16, 2023
@KKould KKould mentioned this pull request Dec 16, 2023
Open
12 tasks
@KKould KKould self-assigned this Dec 16, 2023
@KKould KKould merged commit 33a310c into KipData:main Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guojidan guojidan guojidan approved these changes

Assignees

@KKould KKould

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DDL Support
2 participants
@KKould @guojidan