Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the hardcoded copyright year #70

Conversation

MrDBC
Copy link
Contributor

@MrDBC MrDBC commented Oct 14, 2023

Closes #33

what does this PR do?

it removes the hardcoded copyright year at the footer of the application, and uses script to change the year dynamically

  • [x ] My code follows the code style of this project.
  • [x ] This PR does not contain plagiarized content.
  • [x ] The title of my pull request is a short description of the requested changes.
  • I am a participant of Hacktoberfest 2022.

📷 Screenshots

image

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for medstats-health-journal ready!

Name Link
🔨 Latest commit f0b92ed
🔍 Latest deploy log https://app.netlify.com/sites/medstats-health-journal/deploys/652adcecffe9430008f6aa4a
😎 Deploy Preview https://deploy-preview-70--medstats-health-journal.netlify.app/login
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 14, 2023
@KiranAminPanjwani
Copy link
Owner

image

please remove the gray background color from here.

@MrDBC
Copy link
Contributor Author

MrDBC commented Oct 14, 2023

image

please remove the gray background color from here.

ok @KiranAminPanjwani
so the background should be transparent , right?

@KiranAminPanjwani
Copy link
Owner

BTW, the issue wasn't assigned to you.

@MrDBC
Copy link
Contributor Author

MrDBC commented Oct 14, 2023

BTW, the issue wasn't assigned to you.

the issue was inactive since 3 days, and it was a simple modification, so i took up the opportunity

See if you need any more modifications?

@KiranAminPanjwani
Copy link
Owner

image
Please improve footer section.

@MrDBC
Copy link
Contributor Author

MrDBC commented Oct 14, 2023

@KiranAminPanjwani

  1. I think we can remove the gap between the login and the footer section
  2. also its best if we can remove the scroll bars

Do you have anything else in mind?
like adding a background color to the footer section?

image

@KiranAminPanjwani KiranAminPanjwani merged commit 40ea304 into KiranAminPanjwani:main Oct 14, 2023
4 checks passed
@KiranAminPanjwani KiranAminPanjwani added Hacktoberfest'23 Hacktoberfest 2023 presented by DigitalOcean hacktoberfest-accepted Accepted PR under Hacktobefest 2023 labels Oct 14, 2023
@MrDBC MrDBC deleted the fix/copyright-year-dynamic-generation branch October 15, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest'23 Hacktoberfest 2023 presented by DigitalOcean hacktoberfest-accepted Accepted PR under Hacktobefest 2023
Projects
None yet
2 participants