Implement addField for Aggregate #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
commented
Jun 23, 2024
| * the value of the new field | ||
| * @return | ||
| * the \$addFields pipeline stage [[https://www.mongodb.com/docs/manual/reference/operator/aggregation/addFields/]] | ||
| * @since 3.4 |
There was a problem hiding this comment.
I got the version from: https://www.mongodb.com/docs/v3.4/reference/operator/aggregation/addFields/
|
Looks good, however could you please change the name of the method from Or maybe change the implementation to allow adding multiple fields at once? |
lenguyenthanh
force-pushed
the
aggregate-add-fields
branch
from
e07e7f4
to
85c2287
Compare
|
Looking good. thank you very much 👍 |
|
I updated so now We have two versions of oops you merged it when I'm writing this comment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #40
Couldn't help my self to implement it before your answer, as I need to use this in our project.
p/s: It works in my machine