Lock around accesses to deduplicationMap.

Now that binlog loading is multi-threaded, we need to ensure safe access to the dictionary.
KirillOsenkov · Mar 26, 2023 · d1c4eff · d1c4eff
1 parent 8ef7b3e
commit d1c4eff
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/src/StructuredLogger/Serialization/StringCache.cs b/src/StructuredLogger/Serialization/StringCache.cs
@@ -59,19 +59,25 @@ public string Intern(string text)
                 text = text.NormalizeLineBreaks();
             }
 
-            if (deduplicationMap.TryGetValue(text, out string existing))
+            lock (deduplicationMap)
             {
-                return existing;
-            }
+                if (deduplicationMap.TryGetValue(text, out string existing))
+                {
+                    return existing;
+                }
 
-            deduplicationMap[text] = text;
+                deduplicationMap[text] = text;
+            }
 
             return text;
         }
 
         public bool Contains(string text)
         {
-            return deduplicationMap.ContainsKey(text);
+            lock (deduplicationMap)
+            {
+                return deduplicationMap.ContainsKey(text);
+            }
         }
 
         public IDictionary<string, string> InternStringDictionary(IDictionary<string, string> inputDictionary)