-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate website to Jekyll (Closes #9) #10
base: master
Are you sure you want to change the base?
Conversation
- Individual questions are stored in a collection - A for loop renders all questions in the order of their filenames
returning here to see I never did this, @KirstieJane do you consider yourself more familiar with Jekyll? Otherwise we can probably ask Aurelia once she is done with doing ALL THE THINGS |
Waaaaay back in the day @RaoOfPhysics was mega super awesome and I was like "woah I don't know jekyll". Well today, I finally got advanced enough to check this out and load it up locally. It looks freaking awesome. THANK YOU @RaoOfPhysics!! @daniellecrobinson - I'm happy to merge if you're ok with it... There are merge errors but that's because there have been a few updates to the index.html file since Achintya forked this. I'm pretty sure I can figure them out, but once I merge you might want to have another little read through to check 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran this locally and it all worked perfectly 😄
@KirstieJane: If you let me know what needs updating, I can give it a go at my end (or I can simply dig through the changes since my PR…). |
Wait, the issues are in https://github.com/KirstieJane/OpenAdvice/pull/10/conflicts I'll see what I can do. I'll push more commits to this PR. Don't merge it just yet. :) |
Thank you @RaoOfPhysics!! I know @daniellecrobinson is on holiday at the moment which is why she hasnt' replied etc, if you have any questions I think she'll be back online from next week 😄 No merging on my end until you say so 🌮 |
I've tested this locally and it works well. Might be good if someone more familiar with Jekyll takes a look before you merge this.