Merge pull request #57 from Kiryuumaru/feat/add-convenient-members

Added non-append Success variants

TransactionHelpers/Interface/IResult.cs

@@ -39,6 +39,20 @@ public interface IResult
     /// </summary>
     void ThrowIfError();
 
+    /// <summary>
+    /// Checks if the result has an error.
+    /// </summary>
+    /// <returns>True if the result has an error, otherwise false.</returns>
+    [MemberNotNullWhen(false, nameof(Error))]
+    bool Success();
+
+    /// <summary>
+    /// Checks if the result has an error or no value.
+    /// </summary>
+    /// <returns>True if the result has an error, otherwise false.</returns>
+    [MemberNotNullWhen(false, nameof(Error))]
+    bool SuccessAndHasValue();
+
     /// <summary>
     /// Appends the specified result and checks if the appended result has an error.
     /// </summary>
@@ -174,4 +188,29 @@ public interface IResult<TValue> : IResult
     /// <exception cref="EmptyResultException">the <see cref="IResult{TValue}.Value"/> has no value.</exception>
     [MemberNotNull(nameof(Value))]
     TValue GetValueOrThrow();
+
+    /// <summary>
+    /// Checks if the result has an error.
+    /// </summary>
+    /// <param name="value">The out result value.</param>
+    /// <returns>false if the result has an error or no value, otherwise true.</returns>
+    [MemberNotNullWhen(false, nameof(Error))]
+    bool Success(out TValue? value);
+
+    /// <summary>
+    /// Checks if the result has an error or no value.
+    /// </summary>
+    /// <returns>True if the result has an error, otherwise false.</returns>
+    [MemberNotNullWhen(false, nameof(Error))]
+    [MemberNotNullWhen(true, nameof(Value))]
+    new bool SuccessAndHasValue();
+
+    /// <summary>
+    /// Checks if the result has an error.
+    /// </summary>
+    /// <param name="value">The out result value.</param>
+    /// <returns>false if the result has an error or no value, otherwise true.</returns>
+    [MemberNotNullWhen(false, nameof(Error))]
+    [MemberNotNullWhen(true, nameof(Value))]
+    bool SuccessAndHasValue([NotNullWhen(true)] out TValue? value);
 }

TransactionHelpers/Result.cs

@@ -45,6 +45,20 @@ public virtual void ThrowIfError()
         }
     }
 
+    /// <inheritdoc/>
+    [MemberNotNullWhen(false, nameof(Error))]
+    public bool Success()
+    {
+        return !IsError;
+    }
+
+    /// <inheritdoc/>
+    [MemberNotNullWhen(false, nameof(Error))]
+    public bool SuccessAndHasValue()
+    {
+        return !IsError;
+    }
+
     /// <inheritdoc/>
     [MemberNotNullWhen(false, nameof(Error))]
     public bool Success<TAppend>(TAppend resultAppend, bool appendResultValues)
@@ -188,6 +202,17 @@ public class Result<TValue> : Result, IResult<TValue>
 {
     internal TValue? InternalValue;
 
+    /// <inheritdoc/>
+    [JsonIgnore]
+    public override Error? Error => base.Error;
+
+    /// <inheritdoc/>
+    public override IReadOnlyList<Error> Errors
+    {
+        get => base.Errors;
+        init => base.Errors = value.ToList();
+    }
+
     /// <inheritdoc/>
     public virtual TValue? Value
     {
@@ -226,6 +251,24 @@ public virtual TValue GetValueOrThrow()
         return Value;
     }
 
+    /// <inheritdoc/>
+    [MemberNotNullWhen(false, nameof(Error))]
+    [MemberNotNullWhen(true, nameof(Value))]
+    public bool Success(out TValue? value)
+    {
+        value = Value;
+        return !IsError;
+    }
+
+    /// <inheritdoc/>
+    [MemberNotNullWhen(false, nameof(Error))]
+    [MemberNotNullWhen(true, nameof(Value))]
+    public bool SuccessAndHasValue([NotNullWhen(true)] out TValue? value)
+    {
+        value = Value;
+        return !IsError && !HasNoValue;
+    }
+
     /// <summary>
     /// Implicit operator for <see cref="Error"/> conversion.
     /// </summary>