Implements facility and routes endpoints #52
Conversation
…n/hello-munnar-backend into feature/facility
…n/hello-munnar-backend into feature/facility
to check if the the facility status is either from open,close or inactive.
pull recent changes
|
This pull request introduces 2 alerts when merging 56ca3d5 into 6b1b7a0 - view on LGTM.com new alerts:
|
| longitude: string; | ||
|
|
||
| @ApiProperty({ type: 'string' }) | ||
| contact: string; |
There was a problem hiding this comment.
What is planning to store here.? can you please give a general view on this
There was a problem hiding this comment.
To store the details about each facility like their address, photos, contact. Each entry belongs to a particular facility type. For eg. Theatres, Museums, View points are entries for a facility type "Entertainment", Hospitals, Medical Shops are part of facility type "Healthcare".
There was a problem hiding this comment.
@arihant-2310 what is planning to store in the field 'contact'? phone number or address ?
| longitude: string; | ||
|
|
||
| @ApiProperty({ type: 'string' }) | ||
| contact: string; |
There was a problem hiding this comment.
What is planning to store here.? can you please give a general view here.
There was a problem hiding this comment.
A data transfer object template which would be required to update an already created facility.
| } | ||
|
|
||
| @Put(':id') | ||
| @Get('/:id') |
There was a problem hiding this comment.
Which data you are calling on this api.
There was a problem hiding this comment.
There may be different types of facilities like Entertainment, Health, Finance etc . To get the details about the particular facility type we used this endpoint.
There was a problem hiding this comment.
@riginoommen we have field in facilities to store the type_id. And this API is part of CRUD of facility_types
|
This pull request introduces 1 alert when merging 6d022c2 into 9a5008d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging b14aeb3 into 6f46180 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 12544a2 into 6f46180 - view on LGTM.com new alerts:
|
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
|
Kudos, SonarCloud Quality Gate passed!
|
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
|
Kudos, SonarCloud Quality Gate passed!
|
2 similar comments
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
Co-authored-by: Sreenadh H <sreenadh@sreenadh.in>
|
Kudos, SonarCloud Quality Gate passed!
|
2 similar comments
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request introduces 1 alert when merging 056ce75 into 6f46180 - view on LGTM.com new alerts:
|
Subject: "<feat #39 >"
Assignees: "Kites-hackathon-squad"
Closes/Fixes/Resolves
Closes #39
Explain the feature/fix
This pull request adds certain end points for creation, updation and deletion of facilities and facility types along with the end point for creation of routes.
Does this PR introduce a breaking change
No
Screenshots
View Screenshots
Ready-for-merge Checklist