New reptilic eyes for dragons and lizans #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Step 5 of issue Kitteh6660#269** - I prefer to use the body part constants rather than their hardcoded numeric values, so I replaced some of them in dragonScore() and lizardScore() - Tiny fix in emberTFs: "[...]You have as many horns as a <del>lizan</del><ins>dragon</ins> can grow." - new PlayerHelper-methods: hasDragonHorns() and hasReptileEyes()
| { | ||
| outputText(" Of course, no feline face would be complete without vertically slit eyes"); | ||
| outputText(!player.hasReptileEyes() ? "." : ", although they come with a second set of eyelids, which is somewhat unusual for a cats face."); | ||
| } | ||
| } |
There was a problem hiding this comment.
That part was somewhat nasty. I guess adding EYES_CAT later would make things easier in the future.
Adding an eyeCount to the player vars, adding hasSpiderEyes() to Creature.as (Similar to isTaur()) and deprecating EYES_FOUR_SPIDER_EYES would be an idea, too. So cats can still have 4 vertically slitted eyes ^^
| case EYES_LIZARD: outputText(" those of a lizard with vertically slitted pupils and green-yellowish irises. They"); break; | ||
| } | ||
| outputText(" come with the typical second set of eyelids, allowing you to blink twice as much as others."); | ||
| } | ||
|
|
There was a problem hiding this comment.
And again the cats face. Well, this time it was easy to implement.
aimozg
pushed a commit
to aimozg/Corruption-of-Champions-Mod
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 5 of issue #269
lizandragon can grow."