KCL stdlib and circle function #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
3 times, most recently
from
5e0383c
to
f806dfd
Compare
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
from
f806dfd
to
3d6fad9
Compare
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
2 times, most recently
from
0c385ca
to
a91e24e
Compare
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
from
a91e24e
to
fe4ab62
Compare
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
from
3af8780
to
312ee46
Compare
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
2 times, most recently
from
7fd193a
to
1b0ea3b
Compare
adamchalmers
commented
Nov 9, 2023
| } | ||
|
|
||
| fn std_lib_fn(&self) -> crate::std::StdFn { | ||
| todo!() |
There was a problem hiding this comment.
@jessfraz this is bad but I don't know what to do here. How is this method actually used for the docs?
adamchalmers
force-pushed
the
achalmers/core-vs-std
branch
from
1b0ea3b
to
c7604dd
Compare
Irev-Dev
approved these changes
Nov 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows stdlib functions to be written as KCL, not as Rust. Rust stdlib functions will hereafter be referred to as "core" not "std".
kcl-stdlib.mp4
Right now the only stdlib function I implemented is a circle function (it's a wrapper around the core
arcfunction which sets the arc's start/end to 0 and 360 respectively). I know I want to change this function as soon as KCL has enums, which is my next task. So, I don't want users to start using this right away. To that end, I've named this function "unstable_stdlib_circle" not "circle". Once the function is ready to be stabilized, I can rename it to just "circle".Note that this PR modifies the existing "sketch and extrude a cylinder" KCL test so that instead of using a user-defined circle function, it uses the
unstable_stdlib_circlefunction now. And the twenty-twenty tests pass, so we know my stdlib is working 🎉Fixes #922