Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable eslint rule react-hooks/exhaustive-deps #1055

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Nov 10, 2023

Workaround for #1014

I realize this is really not fixing the issue and I'm suggesting that despite this PR we keep #1014 open, but at least all the noisy annotations on PRs will be gone, allowing us to catch new errors and warnings when they arise.

Result: no annotation overflow
image

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 10, 2023 11:24am

@pierremtb pierremtb changed the title Disable react-hooks/exhaustive-deps Disable eslint rule react-hooks/exhaustive-deps Nov 10, 2023
@pierremtb pierremtb marked this pull request as ready for review November 10, 2023 11:48
Copy link
Collaborator

@Irev-Dev Irev-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@pierremtb
Copy link
Collaborator Author

Great thank you @Irev-Dev !

@pierremtb pierremtb merged commit 23adf9d into main Nov 11, 2023
10 checks passed
@pierremtb pierremtb deleted the pierremtb/issue1014 branch November 11, 2023 21:27
@pierremtb pierremtb mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants