Add a console.error when ICE fails #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paultag
force-pushed
the
paultag/error-on-ice-error
branch
3 times, most recently
from
8d45def
to
ce29990
Compare
This is purely cosmetic right now, but I want to try and make it easier to tell when the browser is unable to communicate with the ICE server by writing it to the console. I want to add some Sentry logging in the future, but for now, when we see a stream failing to start, we can at least see what I suspect is the most common trigger in the console. Signed-off-by: Paul R. Tagliamonte <paul@kittycad.io>
paultag
force-pushed
the
paultag/error-on-ice-error
branch
from
ce29990
to
7e7b37f
Compare
Irev-Dev
approved these changes
Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely cosmetic right now, but I want to try and make it easier to tell when the browser is unable to communicate with the ICE server by writing it to the console.
I want to add some Sentry logging in the future, but for now, when we see a stream failing to start, we can at least see what I suspect is the most common trigger in the console.