Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL optional parameters #1087

Merged
merged 3 commits into from
Nov 20, 2023
Merged

KCL optional parameters #1087

merged 3 commits into from
Nov 20, 2023

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Nov 17, 2023

Part of #1006 (comment)

This adds support for optional parameters to the AST. They are declared with a ? suffix, e.g. (x, tag?) => {...}.

This PR does not actually use these optional parameters anywhere. In particular, it does not change the KCL stdlib or any existing function definitions. That will happen in a follow-up PR.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 20, 2023 2:46am

@adamchalmers adamchalmers marked this pull request as ready for review November 17, 2023 23:52
@adamchalmers adamchalmers merged commit 6afacd7 into main Nov 20, 2023
29 of 31 checks passed
@adamchalmers adamchalmers deleted the achalmers/kcl-optional-params branch November 20, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant