more e2e export fixes #1150
Merged
more e2e export fixes #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
commented
Nov 30, 2023
Comment on lines
-37
to
+38
| return | ||
| } | ||
| return |
There was a problem hiding this comment.
This fixes the below
Screenshare.-.2023-11-30.4_22_27.PM.mp4
| @@ -210,11 +210,36 @@ const part001 = startSketchOn('-XZ') | |||
| const downloadPromise = page.waitForEvent('download') | |||
| await page.getByRole('button', { name: 'Export', exact: true }).click() | |||
| const download = await downloadPromise | |||
| const downloadLocationer = (extra = '') => | |||
There was a problem hiding this comment.
The below waits for two downloads when it's gltf-standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #833
More fixes to export tests, and exports
Note that the export e2e tests can't test file picker-related problems, of which there are some fixes in here for.
Outstanding is what to do about gltf-standard exports as they are two files
#1151