Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default extrude distance expression to something more sensible, like 5 #2351

Merged
merged 10 commits into from
May 17, 2024

Conversation

franknoirot
Copy link
Collaborator

I thought this was a note in #2035 at some point, but we don't need to show users that this input is an expression editor, they'll learn that when they edit text within it. Just put a value with a half-decent chance of being useful in there.

Copy link

qa-wolf bot commented May 14, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview May 17, 2024 2:16pm

@franknoirot
Copy link
Collaborator Author

franknoirot commented May 14, 2024

@Irev-Dev this screenshot is technically correct but is it icky that the extrusion's disconnected?

@Irev-Dev
Copy link
Collaborator

I think it's fine, you can move the start sketch at if you care.

@franknoirot franknoirot merged commit 1b87886 into main May 17, 2024
16 checks passed
@franknoirot franknoirot deleted the franknoirot/sensible-extrude-default branch May 17, 2024 14:29
@franknoirot franknoirot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants