Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double-clicking a model file (obj, stl, etc) will auto generate a file with an import statement and open it #2400

Merged
merged 3 commits into from
May 20, 2024

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented May 20, 2024

part of #858

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

qa-wolf bot commented May 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app 🛑 Canceled (Inspect) May 20, 2024 0:45am

@jessfraz
Copy link
Contributor Author

cc @r-barton who noticed this as well

@jessfraz jessfraz enabled auto-merge (squash) May 20, 2024 00:38
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 86.28%. Comparing base (15418e9) to head (3e575c9).

Files Patch % Lines
src/wasm-lib/kcl/src/settings/types/file.rs 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2400      +/-   ##
==========================================
- Coverage   86.39%   86.28%   -0.12%     
==========================================
  Files          59       59              
  Lines       24508    24541      +33     
==========================================
  Hits        21174    21174              
- Misses       3334     3367      +33     
Flag Coverage Δ
wasm-lib 86.28% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit a9ab35e into main May 20, 2024
18 of 22 checks passed
@jessfraz jessfraz deleted the open-model-files branch May 20, 2024 00:45
@Irev-Dev Irev-Dev mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant