Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to toggle scale grid visibility #2838

Merged
merged 11 commits into from
Jul 1, 2024
Merged

Conversation

franknoirot
Copy link
Collaborator

Closes #2835

Demo

Screenshare.-.2024-06-28.1_15_11.AM-compressed.mp4

Copy link

qa-wolf bot commented Jun 28, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 1, 2024 4:22pm

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (5fbbe2f) to head (dd2e043).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2838      +/-   ##
==========================================
- Coverage   86.73%   86.64%   -0.10%     
==========================================
  Files          62       62              
  Lines       24628    24660      +32     
==========================================
+ Hits        21362    21367       +5     
- Misses       3266     3293      +27     
Flag Coverage Δ
wasm-lib 86.64% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz
Copy link
Contributor

playwirght test w snapshots :) jsut wanna make sure we dont break it but we know mike will tell us lol

@franknoirot franknoirot changed the title Franknoirot/grid setting Add setting to toggle scale grid visibility Jul 1, 2024
@jessfraz jessfraz merged commit 8972f53 into main Jul 1, 2024
21 of 23 checks passed
@jessfraz jessfraz deleted the franknoirot/grid-setting branch July 1, 2024 19:31
@jessfraz jessfraz mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make having a grid in 3d mode a setting, default off
2 participants