It remove aria-hidden attribute for hidden element on dialog closing #97
Comments
|
Fair point. |
|
The lib did support this for a while and eventually I removed it as I thought it was some unnecessary optimisation. |
|
Can confirm this is an issue, I reverted to an older version of the script for the time being |
|
In my case it was not a problem because nothing was aria-hidden at the same DOM level than the dialog box. |
|
That’s absolutely true. If someone would like to submit a PR, I’d be glad to review and merge it. :) |
|
Sadly I have 3 dialog boxes on the same page. My workaround was to add surrounding divs to the dialog html |
|
This issue was causing unwanted behavior when I had multiple dialogs on the same page, in all browsers except Chrome. When hiding one dialog, the others were all having their 'aria-hidden' attributes removed and were therefore incorrectly being displayed. I was able to fix this issue by updating a11y-dialog.js line 182 and adding a check so that the hide() method only removed the aria-hidden attribute from non-dialog elements. this._targets.forEach(function(target) { if (target.className !== 'dialog') target.removeAttribute('aria-hidden');}); |
|
Still facing this issue almost 2 years after it has been reported. If I find some time I'll try to propose a fix and Pull Request |
|
Hello. I’m sorry you’re still facing that issue. That being said, the fix is relatively straightforward and can be done without touching the library at all: have two containers side by side, one for the content, one for the dialog. <body>
<div id="root">
<!-- Main app content here -->
</div>
<div id="dialog" aria-hidden="true">
<!-- Dialog here -->
</div>
</body>Wouldn’t that be possible? |
|
this issue should be fixed by the latest change #117 |
When we open a dialog, it put
aria-hiddenattribute totruefor each element of document other than dialog itself.And when we close the dialog box,
aria-hiddenattribute is removed to each of them.But when an element is
aria-hidden="true"yet before opening, a11y-dialog remove the attribute at closing, but it shouldn't.The text was updated successfully, but these errors were encountered: