Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: hide and show functions accept CustomEvent #326

Merged
merged 1 commit into from Mar 25, 2022
Merged

types: hide and show functions accept CustomEvent #326

merged 1 commit into from Mar 25, 2022

Conversation

ZerdoX-x
Copy link
Contributor

Fixes #323

@ZerdoX-x
types: hide and show functions accept CustomEvent
eaba724 
instead of `Event`.
`_fire` private function also affected
@KittyGiraudel
Copy link
Owner

I must say I’m very surprised you’re facing issues just because of typing in JSDoc comments. I wasn’t aware they were that strict and could effectively block implementation details. I’ll issue a fix for this. :)

@KittyGiraudel KittyGiraudel merged commit ab894a1 into KittyGiraudel:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS API: Is there a way to pass data between dialog.open() and dialog.on("open")?
2 participants
@ZerdoX-x @KittyGiraudel