Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reject empty headers / better configuration for ignore headers #33

Merged
merged 5 commits into from
Jul 8, 2017

Conversation

woylie
Copy link
Member

@woylie woylie commented Jul 5, 2017

addresses issue #11 and issue #32

@woylie woylie mentioned this pull request Jul 5, 2017
@woylie woylie changed the title reject empty request headers reject empty headers / better configuration for ignore headers Jul 5, 2017
@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage increased (+0.4%) to 94.521% when pulling 4c198ef on fix/reject-empty-headers into f304ef1 on dev.

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage decreased (-0.4%) to 93.717% when pulling ff031e7 on fix/reject-empty-headers into f304ef1 on dev.

@rhazdon
Copy link
Member

rhazdon commented Jul 8, 2017

Mhh... Coveralls is crying because the coverage decreased.
Could you do me a favour and add a coveralls.json file into the root dir of the project with the following settings:

"coverage_options": {
    "treat_no_relevant_lines_as_covered": true,
    "minimum_coverage": 85
  }

This should fix the issue.

@coveralls
Copy link

coveralls commented Jul 8, 2017

Coverage Status

Coverage decreased (-0.4%) to 93.717% when pulling 3f98f4e on fix/reject-empty-headers into cab200b on dev.

@woylie
Copy link
Member Author

woylie commented Jul 8, 2017

No, that didn't help.

@coveralls
Copy link

coveralls commented Jul 8, 2017

Coverage Status

Coverage decreased (-0.4%) to 93.717% when pulling 3f98f4e on fix/reject-empty-headers into cab200b on dev.

@rhazdon
Copy link
Member

rhazdon commented Jul 8, 2017

But coveralls is green finally. :)

Update:
Nope... mhh...

@coveralls
Copy link

coveralls commented Jul 8, 2017

Coverage Status

Coverage decreased (-0.4%) to 93.717% when pulling 3f98f4e on fix/reject-empty-headers into cab200b on dev.

@rhazdon rhazdon merged commit f6a6cad into dev Jul 8, 2017
@rhazdon rhazdon deleted the fix/reject-empty-headers branch July 8, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants