Dry run fixes

[Neicigam]

• Added Unhealthy Hysteria
• Added option to change Regular RNG probabilities
• Implemented multiple Dawnsparks logic

[KittySparkles]

Very interesting, I like the idea of having this outside of the code itself for better clarity. Maybe we could make this list more explicit like this:

const RNG_DETAILS = {
  W9: {
    FRIENDLY: () => true,
    REGULAR: () => Math.random() > 0.5,
    UNFRIENDLY: () => false
  },
  // …
}

Then we could access the chances like so:

const shouldFrozenCoreStay = RNG_DETAILS[card.id][this.state.RNG]()

[Neicigam]

I moved the calculations to a helper function - This might no longer be needed

[KittySparkles]

You should move this out of the class itself.

const DEFAULT_STATE = { … }

export default class DeckMechanisms extends React.Component {
  constructor(props) {
    super(props)
    
    this.state = { ...DEFAULT_STATE }
  }
}

[Neicigam]

That's what I initially did, but I needed props to define DEFAULT_STATE

[KittySparkles]

You could make it a function then.

const getDefaultProps = () => ({ … })

[Neicigam]

I tried to do so, not sure this is what you meant

[KittySparkles]

Suggested change

	const getBinomialRandomVariableResult = (n, p) => {
	// Iterate over n objects, keep each one with probability p
	// Return how many objects were kept
	// Iterate over n items, keep each one with probability
	// @param {Number} length - Number of items
	// @param {Float} probability - Probability
	// @return Number of items that were kept
	const getBinomialRandomVariableResult = (length, probability) => {

[KittySparkles]

I feel like this should be done in switch; that’s why we have the switch in the first place.

case 'REGULAR': {
  // …
  state.mana += getBinomialRandomVariableResult(activeDawnsparks, DAWNSPARKS_HITS) * 4
  // …
  break
}

[Neicigam]

I wanted to add mana from FC and Dawnsparks in the same place for clarity, but I'll move it

[KittySparkles]

We tend to use camelCase in JavaScript, so maybe you could change them for sequenceLength and successProbability. But otherwise it looks super nice. 👍

[KittySparkles]

Let’s remove that change from this pull-request and do it separately with a test? :)

[KittySparkles]

I don’t think the comment is correct?

[KittySparkles]

How comes you are recomputing it a second time? It seems you did it once on L382 already.

[Neicigam]

Once to remove Dawnsparks that were killed by the opponent, once to calculate how many of those who survived actually hit an enemy unit and give mana

[KittySparkles]

Ah yes, of course!