Update Push Notifications credentials #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,12 +22,12 @@ import Foundation | |||
| public class PushSDKCredentials { | |||
|
|
|||
| public let appGuid : String | |||
| public let appSecret : String | |||
| public let apiKey : String | |||
There was a problem hiding this comment.
This is SemVer Major, of course.
There was a problem hiding this comment.
Yes - 9.0.0
There was a problem hiding this comment.
We released 8.0.0 when Watson migrated to IAM credentials in June, and made similar changes for those services.
dingwilson
approved these changes
Aug 31, 2018
ianpartridge
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a credentials change by IBM's Push Notifications service, which previously used
appSecretalong withregionandappGuidto authenticate with the service. The IAM-based credential set now usesapikeyinstead ofappSecretto authenticate with the service.These credential changes are present in version 0.9.0 of the Push Notifications SDK.