Load relative to project #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several problems with using the 0-th command-line argument, including not being accurate when run via the PATH and complications when it is not an absolute path. Fortunately, Foundation provides Bundle.main.executableURL. However, at present this is nil on Linux, so an alternative, working Linux implementation is provided under a conditional in this commit.
This was referenced Mar 11, 2017
|
Changes included in PR #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves robustness of identifying executable location and adds support for BasePath.project which allows file loading relative to the project directory (location of the Package.swift as determined by traversing up the directory structure, starting from the executable folder, defaulting to the executable folder if not found).
It also includes unit tests for relative loading for each BasePath type.