Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert " Build urlURL using URLComponents" #153

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

pushkarnk
Copy link
Contributor

This reverts commit 46fbee0.

These commit has caused many regressions in Kitura tests. Most of the 124 failures are around percent encoding and queries. I was able to debug one of the issues:

_urlComponents?.path = _urlString isn't enough. We'd need the split the _urlString into path and query and take care of percent encoding.

This brings down the number of failures to 30. But it also cancels out any of the performance gains we saw with this change.

Because this commit has been tagged, I am reverting it and opening an issue to investigate further.

@pushkarnk pushkarnk mentioned this pull request Jan 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #153 into master will increase coverage by 0.15%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   66.56%   66.71%   +0.15%     
==========================================
  Files          20       20              
  Lines        1301     1298       -3     
==========================================
  Hits          866      866              
+ Misses        435      432       -3
Flag Coverage Δ
#KituraNet 66.71% <70%> (+0.15%) ⬆️
Impacted Files Coverage Δ
Sources/KituraNet/HTTP/HTTPServerRequest.swift 71.69% <70%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd32df...c0988ea. Read the comment docs.

@pushkarnk pushkarnk merged commit a201972 into Kitura:master Jan 19, 2019
@pushkarnk pushkarnk deleted the regression-urlURL branch May 26, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants