-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to the Kitura-router the ability to add error handlers #15
Comments
The error handler is going to be inspired by express: However we would like it to be a separate function with a use like router.error(). The library will pass any errors to these entities in the order they were written. |
Once validated the router error-handling branch needs to be merged into develop and tagged. Then Package.swift needs to be updated in the Kitura error-handling branch and afterwards, merged into develop. |
Assigning to me for validation. |
@dfirsht Looks good! Can you double check that line 331 in Sources/KituraRouter/Router.swift is using the logger instead of the print statement?
Other than that, I think you can merge. |
Confirmed, merged both branches into develop. |
Add to the Kitura router the ability to add error handlers which can be invoked when a handler or middleware indicates that it encountered an error. This error handler could be the part of a server application that creates and returns the error page.
The text was updated successfully, but these errors were encountered: