fix: Ensure input types are modelled by SwaggerGenerator #1331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that input types are included in the list of types (models) described in Kitura's generated swagger. I also added a check to avoid duplicating effort to build the same model where the same type appears in multiple routes (a common occurrence).
Motivation and Context
Fixes a bug in the SwaggerGenerator where the generated swagger document could refer to a model that was not described.
This affected routes that have both an input and output type, but no identifier (eg. POST). For such routes, the input type was not added to the list of models, and so the document was invalid if that same type was not also used as an output type.
How Has This Been Tested?
The changes pass the existing tests. I have not added a specific test to cover this case in this PR, but intend to do so in a follow-up one.
Checklist: