Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make base64url Data extensions public #75

Merged
merged 4 commits into from
Sep 27, 2019
Merged

feat: Make base64url Data extensions public #75

merged 4 commits into from
Sep 27, 2019

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Sep 24, 2019

Resolves #74

@djones6 djones6 added the jazzy-doc When applied to a PR, instructs Package-Builder to regenerate the Jazzy documentation label Sep 24, 2019
@ianpartridge
Copy link
Contributor

I'm not sure this is a good idea. What if a user of Swift-JWT also depends on another SPM package, which has an identical extension? Build failure.

In general I don't think we should add public API to types we don't control. The same goes for adding public protocol conformances.

@djones6 djones6 mentioned this pull request Sep 27, 2019
Closed
@djones6 djones6 merged commit 3d4e117 into master Sep 27, 2019
@djones6 djones6 deleted the base64url-public branch September 27, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianpartridge ianpartridge ianpartridge approved these changes

Assignees
No one assigned
Labels
jazzy-doc When applied to a PR, instructs Package-Builder to regenerate the Jazzy documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make func base64urlEncodedString() public?
3 participants
@djones6 @ianpartridge @SwiftDevOps