-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bluecryptor to 1.0.2. add swift 4.1 support #73
Conversation
Package.swift
Outdated
@@ -16,7 +16,7 @@ let package = Package( | |||
// .package(url: /* package url */, from: "1.0.0"), | |||
.package(url: "https://github.com/IBM-Swift/BlueSocket.git", .upToNextMinor(from: "0.12.0")), | |||
.package(url: "https://github.com/IBM-Swift/BlueSSLService.git", .upToNextMinor(from: "0.12.0")), | |||
.package(url: "https://github.com/IBM-Swift/BlueCryptor.git", .upToNextMinor(from: "0.8.0")), | |||
.package(url: "https://github.com/IBM-Swift/BlueCryptor.git", .upToNextMinor(from: "1.0.0")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might like to consider loosening this to just .from("1.0.0")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about upToNextMajor
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay. I'll do that. from
just sounds a bit scary in that it would pick up a new major as well.
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 87.53% 87.75% +0.21%
==========================================
Files 12 12
Lines 634 645 +11
==========================================
+ Hits 555 566 +11
Misses 79 79
Continue to review full report at Codecov.
|
Description
Motivation and Context
How Has This Been Tested?
Checklist: