Issue #25 Abstract mysql types. #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
reviewed
Sep 13, 2018
| @@ -0,0 +1 @@ | |||
| swift build -Xlinker -L/usr/local/lib -Xlinker -lmysqlclient -Xcc -I/usr/include/** | |||
There was a problem hiding this comment.
Why is this file and .swift-test-linux not the same? They have a different include path (/usr/include/** vs /usr/local/include/)
These files are a Package-Builder thing, not an SPM thing, right? Is there an SPM mechanism that relieves normal users from having to include the options?
| osx_image: xcode9.4 | ||
| sudo: required | ||
| env: | ||
| - SWIFT_SNAPSHOT=swift-4.2-DEVELOPMENT-SNAPSHOT-2018-06-04-a MYSQL_VER=5 |
There was a problem hiding this comment.
Now that Travis has an xcode10 image I think we can move up to a newer 4.2 snapshot
| int wrapper_mysql_library_init(int argc, char **argv, char **groups) | ||
| { | ||
| return mysql_library_init(0, NULL, NULL); | ||
| } |
There was a problem hiding this comment.
Do we need to wrapper every mysql function? Can we not just wrapper the few where a conversion needs to happen?
|
This has been superseded by pull request 36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a c wrapper which provides type consistency irrespective of the level of mysql plugin.