Skip to content

Commit

Permalink
BUG: Fixing escaping issue
Browse files Browse the repository at this point in the history
  • Loading branch information
Julien Jomier committed Oct 12, 2014
1 parent dad404e commit 63182ce
Showing 1 changed file with 14 additions and 15 deletions.
29 changes: 14 additions & 15 deletions ajax/showtestmeasurementdatagraph.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
$testid = pdo_real_escape_numeric($_GET["testid"]);
$buildid = pdo_real_escape_numeric($_GET["buildid"]);
@$zoomout = $_GET["zoomout"];
$measurementname = htmlspecialchars(pdo_real_escape_string($_GET["measurement"]));

$measurement = preg_replace('/[^\da-z]/i', "", $_GET["measurement"]);
$measurementname = htmlspecialchars(pdo_real_escape_string(stripslashes($measurement)));

if(!isset($buildid) || !is_numeric($buildid))
{
Expand Down Expand Up @@ -79,18 +79,18 @@
ORDER BY build.starttime DESC
");

$tarray = array();
while($build_array = pdo_fetch_array($previousbuilds))
{
$t['x'] = strtotime($build_array["starttime"])*1000;
$time[] = date("Y-m-d H:i:s",strtotime($build_array["starttime"]));
$t['y'] = $build_array["value"];
$t['builid'] = $build_array["id"];
$t['testid'] = $build_array["testid"];

$tarray[]=$t;
}
if($_GET['export']=="csv") // If user wants to export as CSV file
$tarray = array();
while($build_array = pdo_fetch_array($previousbuilds))
{
$t['x'] = strtotime($build_array["starttime"])*1000;
$time[] = date("Y-m-d H:i:s",strtotime($build_array["starttime"]));
$t['y'] = $build_array["value"];
$t['builid'] = $build_array["id"];
$t['testid'] = $build_array["testid"];

$tarray[]=$t;
}
if(@$_GET['export']=="csv") // If user wants to export as CSV file
{
header("Cache-Control: public");
header("Content-Description: File Transfer");
Expand All @@ -101,7 +101,6 @@
for($c=0;$c<count($tarray);$c++) $filecontent .= "{$time[$c]};{$tarray[$c]['y']}\n";
echo ($filecontent); // Start file download
die; // to suppress unwanted output

}
?>
&nbsp;
Expand Down

0 comments on commit 63182ce

Please sign in to comment.