Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socialite: Bake callback URL defaults into the configuration values for each option #2150

Closed
josephsnyder opened this issue Apr 26, 2024 · 3 comments · Fixed by #2180
Closed

Socialite: Bake callback URL defaults into the configuration values for each option #2150

josephsnyder opened this issue Apr 26, 2024 · 3 comments · Fixed by #2180
Assignees
@josephsnyder
Labels
bug report

Comments

@josephsnyder
Copy link
Member

josephsnyder commented Apr 26, 2024 •
edited

Bug report

Expected Behavior

Following the .env examples in the documentation (for GitLab but likely for others), Filling out the files would allow us to use the OAuth provider to sign in.

Ensure that the Socialite Providers have an automatically generated callback URL given to the configuration settings

Actual Behavior

It errors because the user is not informed that the redirect URL needs to be added as one of the environment variables. See: #2032

CDash Version

Additional Information
@josephsnyder josephsnyder self-assigned this Apr 26, 2024
@zackgalbreath
Copy link
Contributor

Rather than update the docs, is this something we can bake into CDash itself?

The redirect URI shouldn't need to be a configuration setting, we should be able to construct it automatically based on the value of app.url right?

@josephsnyder
Copy link
Member Author

@zackgalbreath, it should be. Thanks for pointing that out! Following the example in #2144, we should be able to use that same url() function here to introduce a default.

@josephsnyder josephsnyder changed the title OAuth Documentation doesn't describe the setting up of the Callback URL Socialite: Bake callback URL defaults into the configuration values for each option Apr 26, 2024
@josephsnyder josephsnyder mentioned this issue Apr 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 30, 2024
@josephsnyder
Introduce default callback URI for Socialite (#2180)
abc2a85 
Remove the ability to configure the callback URI for the Socialite
providers that CDash uses for Oauth. Each URL will be formatted to
follow the following string:

    <CDash URL>/auth/<provider>/callback

Fixes #2150
@williamjallen
Copy link
Collaborator

Closed by #2180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephsnyder josephsnyder

Labels
bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce default callback URI for Socialite Kitware/CDash
3 participants
@zackgalbreath @josephsnyder @williamjallen