Make PostgreSQL install more robust #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had an implicit assumption that a database would exist that shares its name with our db user. Instead, attempt to connect to the CDash PostgreSQL database, since it is not created for you during the install step anyway.
|
Personally, I would be inclined to do exactly the same thing for both databases, i.e., require the user to create the database and grant the necessary permissions, but in principle LGTM. |
|
👍 to @jamiesnape's suggestion. |
zackgalbreath
added a commit
that referenced
this pull request
Nov 10, 2015
Make PostgreSQL install more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had an implicit assumption that a database would
exist that shares its name with our db user. Instead, attempt to
connect to the CDash PostgreSQL database, since it is not created
for you during the install step anyway.