Use exponential backoff when requeueing Done.xml files #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
These changes seem reasonable to me. In the future, it might be worthwhile to look into Laravel's job batching and job chaining features instead. Doing so would require a significant refactor of the submission process though.
After the recent upgrade of open.cdash.org, we noticed many builds were no longer marked as "Done". This was due to the Done.xml handler exhausting its 5 retries while a single large Test.xml file was in the process of being parsed. We solve this problem by exponentially backing off the requeueing of Done.xml files to give CDash more time to finish parsing any such large XML files for a given build. Fixes #1603
It is possible for this method to return null if the build's Site cannot be located for any reason.
williamjallen
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent upgrade of open.cdash.org, we noticed many builds were no longer marked as "Done". This was due to the Done.xml handler exhausting its 5 retries while a single large Test.xml file was in the process of being parsed.
We solve this problem by exponentially backing off the requeueing of Done.xml files to give CDash more time to finish parsing any such large XML files for a given build.
Fixes #1603
This PR also contains a couple other semi-related fixes dealing with parallel parsing of submission files.