Fix display of Revision links on viewUpdate.php #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These links were not being shown on viewUpdate.php. The view was expecting the API to return cdash.updates, while the data was actually stored in cdash.update. We also update our integration test for this page to make sure these links are displayed when they should be.
We never return cdash.update.timestamp from the viewUpdate API endpoint, so we can safely remove this section from the view.
bryonbean
approved these changes
Apr 12, 2018
|
Thank you very much for fixing this issue! Just for the record (for other users): This issue was discussed at the mailing list, starting at April 10: "[CDash] Project revision information missing on viewUpdate.php, bugs in AngularJS code?", https://cmake.org/pipermail/cdash/2018-April/001862.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.