Emacs mode: Several additions & adjustments #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
|
Thanks. Please revise the commit messages to start in |
This allows the keywords be defined in a list and reused in different regexps.
|
@bradking Done, hope that looks okay. |
added 3 commits
March 9, 2015 17:04
Rename `unscreamify-cmake-buffer' to `cmake-unscreamify-buffer'. Also, enclose function body with `save-excursion'.
Use `define-derived-mode` as per the recommended method: https://www.gnu.org/software/emacs/manual/html_node/elisp/Derived-Modes.html This automatically handles setup of the syntax table, keymaps, etc.
|
I've rebased to leave out the problem commits https://github.com/roysc/CMake/commit/8f83081b3687857d9f372d31a1de543a78de4148 and https://github.com/roysc/CMake/commit/d9d7b027354f5314f658aaae707bdc67b10f0f84. I'll open a new PR for those later. |
|
Please look at my comment on commit 31420cf. Currently it breaks indentation. Thanks. |
|
I saw that - I have some idea of the problem but I will have to test a bit more carefully this time. Sorry for the mess. |
|
Closing for now. Please re-open when new revisions are ready. |
|
Corresponding CMake issue: |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define cmake-mode properly with
define-derived-modeAdd font-lock for keywords and variables
Rename to
cmake-unscreamify-buffercmake-indent: Make closing parens match opening; clean up some