-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IQR playground image build by upgrading pip, and also auto sense IMAGE_VERSION #379
Conversation
Fixes #376 |
no problem @Purg updated per your comments. |
Might want to also remove the "Build image without using cache" part of the PR title as that is not part of this PR anymore. |
got it, updated the title @Purg and will also go ahead and make the requested changes shortly. |
all changes made |
Changes LGTM. Building images to test. |
We also need a rebase here. |
Oops, apparently I can do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Images built. Caffe importable and callable in python within both CPU and GPU image variants. Pip is correctly version 18.1 in both images as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost forgot (sorry)! We need a change note. In docs/release_notes/pending_release.rst
, add a bullet under the Fixed->Docker section for the Caffe image and that you resolved an issue with upgrading pip for a newer version of matplotlib.
OK no problem release notes updated! @Purg |
…f matplotlib to 2.2.2 b/c well sigh.
… pin the matplotlib.
…sue with upgrading pip for a newer version of matplotlib.
67dfee2
to
c84b1f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting on successful CI.
awesome thanks @Purg |
No description provided.