Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Confidence Pair Alignment Issues #1226

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fixing Confidence Pair Alignment Issues #1226

merged 2 commits into from
Apr 29, 2022

Conversation

BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Apr 14, 2022

fixes #1221

Dataset that demonstrates the issue: https://viame.kitware.com/#/viewer/62584c41f3a0a95bd8eb1f2c

Click the first fish on the left and go to the detailed panel.

Fixing the column sizes allows for proper wrapping of the type text:
image

The one column has a ternary operator to adjust the column width slightly. Without this a single already set confidence value may look weird:
Without ternary operator:
image
(Note additional white space)

With ternary operator:
image

fixes #999

Adds a sorting to the training configuration names after they are updated so they are returned in the proper order for the client. The desktop version already did proper sorting of the training configuration names.

fixes #1219

Modified the input filename paths so that they update if the user happens to type or delete values in there instead of using the default filename loaded.

Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Particularly like the ternary logic for the alignment, clever.
Manually tested each fix and ran integration testing too.

@BryonLewis BryonLewis merged commit d5fde6a into main Apr 29, 2022
@BryonLewis BryonLewis deleted the client/fix-1221 branch April 29, 2022 14:04
marySalvi pushed a commit that referenced this pull request May 9, 2022
* css change

* fix import and training order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants