Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job queue size #1267

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Job queue size #1267

merged 2 commits into from
Jul 12, 2022

Conversation

subdavis
Copy link
Contributor

@subdavis subdavis commented Jul 5, 2022 •
edited

Show the size of the job queue to all users.

This is an imperfect solution because when another user in the system creates a job, it won't show up here because User A won't get push notifications about user B's jobs. It will update for changes in User A's job status, but otherwise might require a page reload to be correct.

fixes #1260

Screenshot from 2022-07-05 16-45-32

BryonLewis
BryonLewis requested changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works mostly as intended. I think that the having the number of awaiting jobs may be necessary to indicate that there are X items in the queue currently instead of the currently in progress jobs.

server/dive_server/views_override.py Outdated Show resolved Hide resolved
server/dive_server/views_override.py Show resolved Hide resolved
@BryonLewis BryonLewis self-requested a review July 6, 2022 15:01
BryonLewis
BryonLewis approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BryonLewis BryonLewis merged commit fa4d64e into main Jul 12, 2022
@BryonLewis BryonLewis deleted the job-queue-size branch July 12, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryonLewis BryonLewis BryonLewis approved these changes

@marySalvi marySalvi Awaiting requested review from marySalvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show all users the job queue size.
2 participants
@subdavis @BryonLewis